Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VAR_LIST to LIST #3170

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Rename VAR_LIST to LIST #3170

merged 1 commit into from
Apr 1, 2024

Conversation

manh9203
Copy link
Contributor

This PR renamed LogicalType and PhysicalType VAR_LIST to LIST.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 94.68439% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 92.18%. Comparing base (ac9cbf3) to head (724c6c1).

Files Patch % Lines
src/common/arrow/arrow_array_scan.cpp 42.85% 4 Missing ⚠️
src/common/arrow/arrow_row_batch.cpp 76.92% 3 Missing ⚠️
src/storage/store/list_column_chunk.cpp 94.33% 3 Missing ⚠️
tools/python_api/src_cpp/py_connection.cpp 66.66% 2 Missing ⚠️
src/common/arrow/arrow_type.cpp 50.00% 1 Missing ⚠️
src/common/types/ku_list.cpp 0.00% 1 Missing ⚠️
src/include/storage/store/list_column_chunk.h 66.66% 1 Missing ⚠️
...rator/persistent/reader/parquet/parquet_reader.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3170      +/-   ##
==========================================
- Coverage   92.19%   92.18%   -0.01%     
==========================================
  Files        1156     1156              
  Lines       43967    43965       -2     
==========================================
- Hits        40535    40531       -4     
- Misses       3432     3434       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manh9203 manh9203 merged commit a99ff6c into master Apr 1, 2024
17 checks passed
@manh9203 manh9203 deleted the rename-var-list branch April 1, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants