Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension issues #4011

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Fix extension issues #4011

merged 2 commits into from
Aug 2, 2024

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Aug 2, 2024

Description

Closes #4004: Give better error message in extension:
Closes #4006: Give better error message in non-empty wal
Closes #4009: Add default name for unaliased database

Add tests for http_file_cache in a single transaction.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.15%. Comparing base (eccab34) to head (2972ddd).
Report is 3 commits behind head on master.

Files Patch % Lines
src/main/attached_database.cpp 0.00% 2 Missing ⚠️
src/processor/operator/simple/attach_database.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4011      +/-   ##
==========================================
- Coverage   85.16%   85.15%   -0.01%     
==========================================
  Files        1297     1297              
  Lines       50640    50646       +6     
  Branches     6946     6949       +3     
==========================================
+ Hits        43128    43130       +2     
- Misses       7382     7386       +4     
  Partials      130      130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 2, 2024

Benchmark Result

Master commit hash: 1f75636b48a2d134ae9668f4188ba850045c2c55
Branch commit hash: f0624910aea419a3a68f9939e33fa5f96c9300c0

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 664.47 657.89 6.58 (1.00%)
aggregation q28 11731.04 11456.97 274.07 (2.39%)
filter q14 144.14 136.03 8.11 (5.96%)
filter q15 143.43 134.44 8.99 (6.69%)
filter q16 330.86 306.82 24.05 (7.84%)
filter q17 466.84 459.71 7.13 (1.55%)
filter q18 1969.70 1910.40 59.30 (3.10%)
fixed_size_expr_evaluator q07 582.02 573.54 8.48 (1.48%)
fixed_size_expr_evaluator q08 807.08 798.68 8.41 (1.05%)
fixed_size_expr_evaluator q09 802.91 798.85 4.06 (0.51%)
fixed_size_expr_evaluator q10 256.90 249.81 7.09 (2.84%)
fixed_size_expr_evaluator q11 251.32 247.15 4.17 (1.69%)
fixed_size_expr_evaluator q12 252.40 243.92 8.48 (3.48%)
fixed_size_expr_evaluator q13 1498.09 1489.41 8.68 (0.58%)
fixed_size_seq_scan q23 137.63 126.67 10.96 (8.65%)
join q31 50.05 39.47 10.58 (26.80%)
ldbc_snb_ic q35 3501.65 3969.51 -467.86 (-11.79%)
ldbc_snb_ic q36 137.54 122.18 15.36 (12.57%)
ldbc_snb_is q32 9.73 10.60 -0.87 (-8.20%)
ldbc_snb_is q33 97.84 98.03 -0.19 (-0.19%)
ldbc_snb_is q34 95.21 90.78 4.43 (4.88%)
multi-rel multi-rel-large-scan 2692.05 2663.65 28.39 (1.07%)
multi-rel multi-rel-lookup 69.30 83.57 -14.27 (-17.08%)
multi-rel multi-rel-small-scan 58.57 56.90 1.67 (2.93%)
order_by q25 147.11 136.11 10.99 (8.08%)
order_by q26 455.61 460.01 -4.41 (-0.96%)
order_by q27 1422.48 1413.16 9.32 (0.66%)
scan_after_filter q01 184.75 183.18 1.58 (0.86%)
scan_after_filter q02 181.75 172.56 9.18 (5.32%)
shortest_path_ldbc100 q39 119.99 122.08 -2.09 (-1.71%)
var_size_expr_evaluator q03 2072.58 2055.45 17.13 (0.83%)
var_size_expr_evaluator q04 2280.39 2245.80 34.60 (1.54%)
var_size_expr_evaluator q05 2558.64 2536.86 21.78 (0.86%)
var_size_expr_evaluator q06 1386.30 1355.50 30.80 (2.27%)
var_size_seq_scan q19 1493.09 1472.26 20.83 (1.41%)
var_size_seq_scan q20 3172.65 3157.52 15.12 (0.48%)
var_size_seq_scan q21 2386.36 2444.23 -57.87 (-2.37%)
var_size_seq_scan q22 132.12 129.44 2.68 (2.07%)

@acquamarin acquamarin merged commit d2bf0cd into master Aug 2, 2024
30 of 31 checks passed
@acquamarin acquamarin deleted the fix-extension-issues branch August 2, 2024 04:34
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
(cherry picked from commit d2bf0cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants