Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Pass decodedPayload to Decoder.decode method #243

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Dec 19, 2022

What does this PR do ?

Instantiate the DecoderPayload and pass it directly to the Decoder.decode method.

Before

  async decode(
    payload: JSONObject,
  ): Promise<DecodedPayload<DummyTempDecoder>> {
    const decodedPayload = new DecodedPayload<DummyTempDecoder>(this);
    // decode measurements..
    return decodedPayload;
  }

After

  async decode(
    decodedPayload: DecodedPayload<DummyTempDecoder>,
    payload: JSONObject,
  ): Promise<DecodedPayload<DummyTempDecoder>> {
    // decode measurements..
    return decodedPayload;
  }

@Aschen Aschen changed the title Pass decodedPayload to Decoder.decode method [breaking] Pass decodedPayload to Decoder.decode method Dec 19, 2022
@Aschen Aschen merged commit fda20f1 into 2-stable Dec 19, 2022
@Aschen Aschen deleted the chore/directly-pass-decoded-payload branch December 19, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant