-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add from and size parameters in the listCollections route #518
Conversation
Current coverage is 97.34% (diff: 100%)@@ develop #518 diff @@
==========================================
Files 116 116
Lines 5921 5947 +26
Methods 613 615 +2
Messages 0 0
Branches 1145 1152 +7
==========================================
+ Hits 5763 5789 +26
Misses 158 158
Partials 0 0
|
@@ -83,16 +84,21 @@ function ReadController (kuzzle) { | |||
.map(collection => collection.name); | |||
|
|||
if (type === 'realtime') { | |||
return kuzzle.pluginsManager.trigger('data:afterListCollections', new ResponseObject(modifiedRequestObject, {type, collections: {realtime: realtimeCollections}})); | |||
let realtimeResponse = {type, collections: {realtime: realtimeCollections}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we already all agreed node 6 is a strong requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be leveraged for the time being using strict mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benoitvidis I think we did already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benoitvidis added a 'use strict'
fix #440
Response format has changed.
Previously:
Now:
Collections are sorted alphanumerically.
from
andsize
appear in the response only if they have been used in the request.