Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for the collection controller #13

Merged
merged 30 commits into from
Jun 24, 2019

Conversation

scottinet
Copy link
Contributor

⚠️ depends on #12

Description

Add unit tests for the collection controller, and fix a couple of bugs detected thanks to those tests.

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@857f541). Click here to learn what that means.
The diff coverage is 52%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage          ?   29.95%           
=========================================
  Files             ?       19           
  Lines             ?      888           
  Branches          ?      105           
=========================================
  Hits              ?      266           
  Misses            ?      621           
  Partials          ?        1
Impacted Files Coverage Δ
Kuzzle/API/Controllers/DocumentController.cs 0% <0%> (ø)
Kuzzle/Kuzzle.cs 0% <0%> (ø)
Kuzzle/API/Controllers/ServerController.cs 0% <0%> (ø)
Kuzzle/API/Controllers/RealtimeController.cs 0% <0%> (ø)
Kuzzle/API/Options/SearchOptions.cs 100% <100%> (ø)
Kuzzle/API/Controllers/CollectionController.cs 100% <100%> (ø)
Kuzzle/API/Controllers/AuthController.cs 100% <100%> (ø)
Kuzzle/API/Controllers/BaseController.cs 100% <100%> (ø)
Kuzzle/API/DataObjects/SearchResults.cs 26.47% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857f541...db23193. Read the comment docs.

@Aschen Aschen changed the base branch from master to 0-dev June 21, 2019 10:23
@jenow jenow merged commit d51799c into 0-dev Jun 24, 2019
@jenow jenow deleted the unit-tests-collection-controller branch June 24, 2019 09:28
@scottinet scottinet mentioned this pull request Jul 17, 2019
scottinet added a commit that referenced this pull request Jul 18, 2019
# [0.2.0](https://github.com/kuzzleio/sdk-csharp/releases/tag/0.2.0) (2019-07-17)


#### New features

- [ [#22](#22) ] Add Admin controller and unit tests   ([Shiranuit](https://github.com/Shiranuit))
- [ [#23](#23) ] Add Index Controller   ([alexandrebouthinon](https://github.com/alexandrebouthinon))

#### Enhancements

- [ [#14](#14) ] Fix optional parameters design   ([scottinet](https://github.com/scottinet))
- [ [#13](#13) ] Add unit tests for the collection controller   ([scottinet](https://github.com/scottinet))
- [ [#12](#12) ] Add unit tests for the auth controller   ([scottinet](https://github.com/scottinet))
- [ [#11](#11) ] Initialize unit tests project   ([scottinet](https://github.com/scottinet))

#### Others

- [ [#24](#24) ] Rewrite WebSocket class   ([scottinet](https://github.com/scottinet), [alexandrebouthinon](https://github.com/alexandrebouthinon))
- [ [#20](#20) ] Add documentation runner   ([Aschen](https://github.com/Aschen))
- [ [#18](#18) ] Add unit test for Realtime Controller    ([ThomasF34](https://github.com/ThomasF34))
- [ [#17](#17) ] Unit tests kuzzle class   ([Aschen](https://github.com/Aschen))
- [ [#16](#16) ] Add unit tests for the server controller   ([ThomasF34](https://github.com/ThomasF34))
- [ [#15](#15) ] Add unit tests for the document controller   ([scottinet](https://github.com/scottinet))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants