Release 2.0.3 #57
Merged
Release 2.0.3 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description (note: this is the v2 version of this already validated PR: #54 ) When the WebSocket protocol tries to reconnect and, ultimately, fails, it resets the socket, sets it to null, and then changes its own state to `Closed`. This state change triggers a reset which, in turn, force-closes the current socket and sets it to null. Since the socket has already been closed and set to null, this ends up in a NullReferenceException. This PR makes the `WebSocket.ResetState` function reentrant. # Boyscout Use `WebSocket.ResetState` at the end of each reconnection attempt to prevent code duplication.
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
==========================================
+ Coverage 82.19% 82.45% +0.25%
==========================================
Files 34 34
Lines 1674 1676 +2
Branches 194 198 +4
==========================================
+ Hits 1376 1382 +6
+ Misses 275 270 -5
- Partials 23 24 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0.3 (2020-09-17)
Bug fixes