Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Fix token expired #100

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix token expired #100

merged 2 commits into from
Nov 20, 2020

Conversation

Shiranuit
Copy link
Contributor

What does this PR do ?

  • There was an issue where CompletableFutures were not completed exceptionally when there was a TokenExpired error response, causing java applications using the SDK to be locked when doing .get() or .join() on the resulting Task of a controller action,
    because the Future was never resolved.

@Shiranuit Shiranuit changed the base branch from master to 3-dev November 20, 2020 16:26
@Shiranuit Shiranuit self-assigned this Nov 20, 2020
@Shiranuit Shiranuit merged commit 8f07731 into 3-dev Nov 20, 2020
@Shiranuit Shiranuit deleted the fix-token-expired branch November 20, 2020 16:42
@Shiranuit Shiranuit mentioned this pull request Nov 20, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jenow jenow jenow approved these changes

@Yoann-Abbes Yoann-Abbes Yoann-Abbes approved these changes

Assignees

@Shiranuit Shiranuit

Labels
changelog:bug-fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shiranuit @jenow @Yoann-Abbes