Fix scroll action and next on searchResult #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stafyniaksacha
suggested changes
Jan 19, 2017
| @@ -511,6 +511,10 @@ Collection.prototype.scroll = function (scrollId, options, filters, cb) { | |||
| options = {}; | |||
| } | |||
|
|
|||
| if (!options.scroll) { | |||
| throw new Error('Collection.scroll: scroll is required'); | |||
There was a problem hiding this comment.
scroll parameter is not required to do scroll request (that is only to force refreshing scroll id)
There was a problem hiding this comment.
Hmmm are your sure ? the ES documentation gives always a scroll parameter in its examples:
https://www.elastic.co/guide/en/elasticsearch/reference/5.0/search-request-scroll.html
POST /_search/scroll
{
"scroll" : "1m",
"scroll_id" : "DXF1ZXJ5QW5kRmV0Y2gBAAAAAAAAAD4WYm9laVYtZndUQlNsdDcwakFMNjU1QQ=="
}
(but I did not test it without the parameter, so maybe their documentation is not exactly good)
There was a problem hiding this comment.
As discussed together, LGTM
jenow
approved these changes
Jan 19, 2017
ballinette
approved these changes
Jan 19, 2017
stafyniaksacha
approved these changes
Jan 19, 2017
This was referenced Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.