-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLES explicit bindings #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
changed the title
Share the binding population logic between backends
GLES explicit bindings
Apr 3, 2024
kvark
force-pushed
the
vertex
branch
5 times, most recently
from
April 4, 2024 06:02
1aa6f38
to
8e3edf5
Compare
mikayla-maki
added a commit
to zed-industries/zed
that referenced
this pull request
Apr 10, 2024
Release Notes: - N/A Picks up kvark/blade#105, kvark/blade#97, and more Switches the presentation to be non-blocking, which will improve the latency slightly. Allows to start playing with GLES backend, e.g. ```bash cd crates/gpui RUSTFLAGS="--cfg gles" CARGO_TARGET_DIR=./target-gl cargo run --example hello_world ``` It doesn't currently render properly due to an issue that needs investigation, see kvark/blade#105 (comment) But at least it's a start Co-authored-by: Mikayla Maki <mikayla@zed.dev>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every backend has specifics on how the bindings are treated. But all of them eventually need to ensure the
naga::Module
bindings are filled up, and this process is backend-independent. Now it's done in a separate function.With all the improvements to GLES, it's now able to run the "particle" example on desktop:
RUSTFLAGS="--cfg gles" CARGO_TARGET_DIR=./target-gl cargo run --example particle
TODO: check how it works with Zed