Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pwnwiki.github.io #60

Closed
grutz opened this issue Feb 2, 2014 · 1 comment
Closed

Add support for pwnwiki.github.io #60

grutz opened this issue Feb 2, 2014 · 1 comment
Assignees
Milestone

Comments

@grutz
Copy link
Contributor

grutz commented Feb 2, 2014

(Pwnwiki)[https://github.com/pwnwiki/pwnwiki.github.io] is a great static wiki. Kvasir should easily be able to serve up the files given a path in the kvasir.yaml config file.

@ghost ghost assigned grutz Feb 2, 2014
@grutz
Copy link
Contributor Author

grutz commented Mar 18, 2014

Since pwnwiki is a totally outside/third-party static HTML environment there are some risks to consider.. What if somebody pwns the pwnwiki? It's risky to run this inside the same dom as Kvasir/web2py so a recommended path:

  • set pwnwiki url in kvasir.yaml.sample to the primary wiki URL
  • use a warning page to say you're about to visit an untrusted site and to use private mode
  • allow user to not show the warning for further views during the session

This is a good thing for all external URLs.

@grutz grutz modified the milestones: 1.2, 1.0.1 Mar 19, 2014
@grutz grutz closed this as completed in f2de837 Apr 21, 2014
@grutz grutz modified the milestones: 1.0.1, 1.2 Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant