DRAFT: Update create_database and get_bind for sqlalchemy v2 beta
#674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLalchemy plan on releasing v2.0 of their software in the next week.
create_databaseandget_bindfor quite integral part of thesqlalchemy-utilslibrary and this is my attempted help in addressing the issue as soonest.I'm quite noob, so don't exactly know how to fix the underlying issue, but this is a starting point for the upgrade to support v2.
If someone could kindly give me some guidance, I'd happily try and address the underlying issues.
DRAFT fix #669