Remove PKILL implementation for Istio versions < 1.3 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvij
force-pushed
the
remove_pkill
branch
2 times, most recently
from
1e813c4
to
55d2bf8
Compare
kvij
force-pushed
the
remove_pkill
branch
2 times, most recently
from
6204920
to
cfb1003
Compare
Sending the kill signal was needed for Istio < v1.3 and 1.3 has been released 4 years ago. If the `ENVOY_ADMIN_API` is set to the default port `15000` the `ISTIO_QUIT_API` configured correctly by default. On deployments that restart the containers the shutdown behaviour might be undesirable. The Istio sidecar will be restarted but when the pod has multiple containers that means that meaningful work in the containers that did not crash could be interrupted. So for pods that have multiple containers that need traffic through the service mesh, it is recommended to set `NEVER_KILL_ISTIO` to `true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been 4 years since Istio 1.3 has been released introducing the
/quitquitquitendpoint.It should be safe to remove the kill implementation that was necessary for v1.2 and lower.
If the
ENVOY_ADMIN_APIis set to the default port15000theISTIO_QUIT_APIconfigured correctly by default.On deployments that restart the containers the shutdown behavior might be undesirable.
The Istio sidecar will be restarted but when the pod has multiple containers that means that meaningful work in the containers that did not crash could be interrupted.
So for pods that have multiple containers that need traffic through the service mesh, it is recommended to set
NEVER_KILL_ISTIOtotrue.Fixes redboxllc#33