Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake option WANT_PERL_DOCS to disable doc generation. #2635

Merged
merged 4 commits into from
May 1, 2024

Conversation

ctrlaltca
Copy link
Contributor

@ctrlaltca ctrlaltca commented Apr 30, 2024

Also:

@VVD
Copy link

VVD commented May 1, 2024

Your patch for PERL options (4d6af2e) is better than mine - can build with perl scripting without documentation, but with my patch it's impossible.
But your patch for Threads (2b4af7b) doesn't work - same link error.

@ctrlaltca
Copy link
Contributor Author

But your patch for Threads (2b4af7b) doesn't work - same link error.

Can you please test adding 03fb5fb ?

@VVD
Copy link

VVD commented May 1, 2024

But your patch for Threads (2b4af7b) doesn't work - same link error.

Can you please test adding 03fb5fb ?

With both patches build without errors.

@ctrlaltca ctrlaltca merged commit 2dc7dfe into kvirc:master May 1, 2024
3 of 4 checks passed
@ctrlaltca ctrlaltca deleted the lazy branch May 1, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small optimization of build process: QT_VERSION_MAJOR and WANT_PERL_DOCS
2 participants