Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 fix subsecond durations ms #9

Merged
merged 6 commits into from
Apr 20, 2024
Merged

Conversation

kwhitley
Copy link
Owner

@kwhitley kwhitley commented Apr 20, 2024

The Issue

duration was incorrectly handling sub-second durations, and rounding to the second arbitrarily, rather than using ms. duration should only round to the unit when being part-limited.

@coveralls
Copy link

coveralls commented Apr 20, 2024

Pull Request Test Coverage Report for Build 8767284482

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8762288008: 0.0%
Covered Lines: 59
Relevant Lines: 59

💛 - Coveralls

@kwhitley kwhitley merged commit 59235e2 into v1.x Apr 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants