Expose intializeRuntime timeout #71
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.x #71 +/- ##
===================================
Coverage 100% 100%
===================================
Files 6 6
Lines 57 57
Branches 9 10 +1
===================================
Hits 57 57
Continue to review full report at Codecov.
|
src/getModuleLoader.ts
Outdated
| @@ -30,7 +30,8 @@ type runtimeModuleType = (moduleObject: StringMap) => AsmRuntimeType; | |||
| type getModuleLoaderType = <T, R extends AsmRuntimeType>( | |||
| factoryLoader: (runtime: R, environment: ENVIRONMENT) => T, | |||
| runtimeModule: runtimeModuleType, | |||
| module?: StringMap | |||
| module?: StringMap, | |||
| initializeOpts?: StringMap | |||
There was a problem hiding this comment.
let's make this to be strictly typed:
interface ModuleInitOption {
timeout: number
};
getModuleLoaderType(
... module?: StringMap,
initOptions: Partial<ModuleInitOption> = {})
There was a problem hiding this comment.
and here should be
type getModuleLoaderType = <T, R extends AsmRuntimeType>(
factoryLoader: (runtime: R) => T,
runtimeModule: runtimeModuleType,
module?: StringMap,
{timeout}?: Partial<ModuleInitOption>
) => moduleLoaderType<T>;
src/getModuleLoader.ts
Outdated
| * @returns {moduleLoaderType<T>} Loader function | ||
| */ | ||
| const getModuleLoader: getModuleLoaderType = <T, R extends AsmRuntimeType>( | ||
| factoryLoader: (runtime: R, environment: ENVIRONMENT) => T, | ||
| runtimeModule: runtimeModuleType, | ||
| module?: StringMap | ||
| module?: StringMap, | ||
| initializeOpts?: StringMap |
There was a problem hiding this comment.
and we can destruct directrly:
(... {timeout}: Partial<ModuleInitOption>)
There was a problem hiding this comment.
You'll have to excuse my absolute naivety on this, my typescript-foo is weak. Not too sure what I'm missing here...
module?: StringMap,
- initializeOpts?: StringMap
+ initOptions: (... {timeout}: Partial<ModuleInitOption>)
) => async (environment?: ENVIRONMENT) => {src/getModuleLoader.ts(64,1): error TS1005: '=>' expected.
There was a problem hiding this comment.
... was just to skip rest of params, so what I meant was
type getModuleLoaderType = <T, R extends AsmRuntimeType>(
factoryLoader: (runtime: R, environment: ENVIRONMENT) => T,
runtimeModule: runtimeModuleType,
module?: StringMap,
{timeout}: Partial<InitOptions> = {}
) => moduleLoaderType<T>;
Codecov Report
@@ Coverage Diff @@
## 1.x #71 +/- ##
========================================
- Coverage 100% 98.27% -1.73%
========================================
Files 6 6
Lines 57 58 +1
Branches 9 10 +1
========================================
Hits 57 57
- Partials 0 1 +1
Continue to review full report at Codecov.
|
Expose timeout option to initializeRuntime as per discussion in kwonoj/hunspell-asm#145 (comment)