Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cargo): bump up dependencies #165

Merged
merged 3 commits into from
Jul 28, 2022
Merged

build(cargo): bump up dependencies #165

merged 3 commits into from
Jul 28, 2022

Conversation

kwonoj
Copy link
Owner

@kwonoj kwonoj commented Jul 20, 2022

No description provided.

@izaakschroeder
Copy link

👋 I think this may be necessary for the most recent version of SWC. I tried running this with AVA and got this:

Missing export __transform_plugin_process_impl crates/swc/src/plugin.rs'

I disassembled the most recent published WASM binary and the closest export I see is __plugin_process_impl which is very close. So I'm guessing SWC updated their plugin API from __plugin_process_impl to __transform_plugin_process_impl in some newer version 😄

Let me know if you publish these changes and I will test them! 🎉

@kwonoj
Copy link
Owner Author

kwonoj commented Jul 20, 2022

I think this may be necessary for the most recent version of SWC

Yes, that's correct. Sorry for the inconveniences, currently SWC plugins are under experimental flag that I bring numbers of breaking changes across versions which requires frequent updates to the plugin / host both.

I'm hoping to stablize this sooner to reduce this kind of breakage.

Fyi this PR may break, it looks like I need to fix few things to make things work correctly again. Will update PR once it's resolved.

@izaakschroeder
Copy link

Awesome, thanks so much @kwonoj. Let me know when/if there's anything I can test for you! 😄

@kwonoj kwonoj merged commit b9be55c into main Jul 28, 2022
@kwonoj kwonoj deleted the bump-version branch July 28, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants