Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lapras invalid encounter type. #3380

Closed
Ninjistix opened this issue Feb 3, 2022 · 1 comment
Closed

Lapras invalid encounter type. #3380

Ninjistix opened this issue Feb 3, 2022 · 1 comment
Labels

Comments

@Ninjistix
Copy link
Contributor

Describe the problem
caught two lapras on route 20 in LGE one of them in invalid in pkhex.

To Reproduce
valid 131 - Lapras - 402C5D6CE287.zip
invalid 131 - Lapras - 967A2886F5BC.zip

Screenshots
image

Additional context
none of the Pokémon were edited.

@Ninjistix Ninjistix added the bug label Feb 3, 2022
@kwsch
Copy link
Owner

kwsch commented Feb 4, 2022

notes for fixing:

two tables in the ROM data, lapras is a rare spawn added using the level range of the table; first table 66E7900C070C392B road020 is 37-42, second table 7B2914456ACF2E2A road020_2 is 39-44.
image

encounter bin generator is somehow only using the second table (39-44 permitted).
https://github.com/kwsch/PKHeX.EncounterSlotDumper/blob/78299561976ffaf948a6116d129a8b0fb0511fec/Gen7b/Dumper7b.cs#L63-L80

This also might just be a crossover, and the above "not using first table level range" is incorrect. But the bin generator should be stuffing the 37-42 lapras in with met location 22 (route 20).

@kwsch kwsch closed this as completed in b0197a8 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants