Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell-pop breaks list-registers #53

Closed
wginolas opened this issue Feb 21, 2017 · 3 comments
Closed

shell-pop breaks list-registers #53

wginolas opened this issue Feb 21, 2017 · 3 comments

Comments

@wginolas
Copy link

Hi,

shell-pop uses a keyword symbol as register name (https://github.com/kyagi/shell-pop-el/blob/master/shell-pop.el#L308). This breaks list-register which tries to sort the registers by name.

sort: Wrong type argument: number-or-marker-p, :shell-pop

The docstring of register-alist states that only characters are allowed as register names.
@syohex syohex mentioned this issue Feb 23, 2017
Merged
@syohex
Copy link
Collaborator

syohex commented Feb 23, 2017

I have sent PR about replacing using register implementation at #54.

@wginolas
Copy link
Author

That was fast! Thank you very much!

@syohex
Copy link
Collaborator

syohex commented Feb 23, 2017

Merged #54.

@syohex syohex closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syohex @wginolas