Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing nodemon dependency #56

Merged
merged 2 commits into from
Aug 29, 2020

Conversation

sergioutama
Copy link
Contributor

@sergioutama sergioutama commented Aug 28, 2020

nodemon is missing from basic example dependency

@kyle-mccarthy there is missing dependency on the basic example and I add additional info on readme to run the example

@kyle-mccarthy
Copy link
Owner

kyle-mccarthy commented Aug 28, 2020

Hey thanks for the contribution! Does this also fix #57?

@sergioutama
Copy link
Contributor Author

Hey thanks for the contribution? Does this also fix #57?

This PR does not fix the issue on monorepo.
I need to investigate more on monorepo issue, temporary fix for #57 is by locking next to version 9.4.4
I am not sure what is the implication of locking that version in another use cases or during deployment

Shall I include temporary fix for monorepo in this PR?

The issue i encounter on monorepo seems related to vercel/next.js#15616

@kyle-mccarthy
Copy link
Owner

I will merge this in! I am honestly not sure what the issue is with the mono repo. That is a community contribution which I'm not familiar with. However, I appreciate the time that you took with this issue as well as debugging the other!

@kyle-mccarthy kyle-mccarthy merged commit 0a51218 into kyle-mccarthy:master Aug 29, 2020
@sergioutama
Copy link
Contributor Author

You've done great job with this package, and i really appreciate it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants