Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Dockerfile.aarch64 aarch64 not supported anymore #759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Update Dockerfile.aarch64 aarch64 not supported anymore #759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile.aarch64
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Original credit: https://github.com/jpetazzo/dockvpn

# Smallest base image
FROM aarch64/alpine:3.5
FROM arm64v8/alpine:3.18.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use latest tag? It works fine based on my testing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version of alpine do you have with a tag latest using aarch64?
I am just following docker guidelines saying that the organization aarch64 is depreciated https://hub.docker.com/r/aarch64/alpine

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i was not clear, I meant arm64v8/alpine:latest.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry I didn't understand that!
The problem with not pinning the docker image version is that nothing
guarantee that in the release of the alpine realse will not introduce a
breaking change (e.g. renaming of environmental variable or dependency
problem with the extra packages installed in the docker image).

Feel free to commit on my PR to change the version of the base image by the
latest you tested but I would avoid latest.

Best

On Mon, 27 Nov 2023, 20:46 Barna, @.***> wrote:

@.**** commented on this pull request.

In Dockerfile.aarch64
#759 (comment)
:

@@ -1,7 +1,7 @@

Original credit: https://github.com/jpetazzo/dockvpn

Smallest base image

-FROM aarch64/alpine:3.5
+FROM arm64v8/alpine:3.18.3

Sorry, i was not clear, I meant arm64v8/alpine:latest.

—
Reply to this email directly, view it on GitHub
#759 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACNPBJ7QD26INSZ2U4SI3MDYGT3ZPAVCNFSM6AAAAAA5HOWTMCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJRGMZDMMZQHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


LABEL maintainer="Kyle Manna <kyle@kylemanna.com>"

Expand Down