Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Serve examples in Director GraphQL Playground #417

Merged
merged 19 commits into from
Nov 8, 2019

Conversation

kjaksik
Copy link
Contributor

@kjaksik kjaksik commented Oct 28, 2019

Description

Changes proposed in this pull request:

  • Serve examples in Director GraphQL Playground

Related issue(s)
See #105

components/director/cmd/examples/README.md Outdated Show resolved Hide resolved
components/director/cmd/main.go Outdated Show resolved Hide resolved
components/director/cmd/main.go Outdated Show resolved Hide resolved
tests/end-to-end/director/examplesaver.go Outdated Show resolved Hide resolved
components/director/examples/README.md Show resolved Hide resolved
Copy link
Contributor

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! Just a few comments

Fix examples prettying

Change the example directory structure into subdirectories

Turn of description decorator plugin unit tests

Apply suggestions from code review

Co-Authored-By: Krystian Cieślik <3641496+crabtree@users.noreply.github.com>

Fix most of the issues mentioned in the cr

mend

Add more fixes for the cr

Fix const names
Copy link
Contributor

@crabtree crabtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just minor comments.

expected, err := ioutil.ReadFile("testdata/expected.graphql")
require.NoError(t, err)
assert.Equal(t, string(expected), string(actual))
err = os.Remove(testOutputFile)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should defer this call right after the file is created (I assume after line 25).

func TestMutateConfig(t *testing.T) {
// GIVEN

t.Run("Succes", func(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success

tests/end-to-end/director/examplesaver.go Show resolved Hide resolved
tests/end-to-end/director/examplesaver.go Outdated Show resolved Hide resolved
@pkosiec pkosiec changed the title Add director static documentation POC Serve examples in Director GraphQL Playground Nov 8, 2019
@kjaksik kjaksik merged commit 7657f4c into kyma-incubator:master Nov 8, 2019
@kjaksik kjaksik deleted the generating-static-doc branch November 8, 2019 13:07
DimitarPetrov pushed a commit to DimitarPetrov/compass that referenced this pull request Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants