This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
Serve examples in Director GraphQL Playground #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjaksik
requested review from
akgalwas,
aszecowka,
crabtree,
dbadura,
franpog859,
janmedrek,
kfurgol,
Maladie,
PK85,
pkosiec,
Szymongib and
tgorgol
as code owners
kjaksik
force-pushed
the
generating-static-doc
branch
from
be06904
to
cb43dfa
Compare
crabtree
suggested changes
Nov 5, 2019
components/director/hack/plugins/descriptionsdecorator/plugin.go
Outdated
Show resolved
Hide resolved
components/director/hack/plugins/descriptionsdecorator/plugin.go
Outdated
Show resolved
Hide resolved
components/director/hack/plugins/descriptionsdecorator/plugin.go
Outdated
Show resolved
Hide resolved
components/director/hack/plugins/descriptionsdecorator/testdata/expected.graphql
Show resolved
Hide resolved
components/director/hack/plugins/descriptionsdecorator/testdata/input.graphql
Show resolved
Hide resolved
kjaksik
force-pushed
the
generating-static-doc
branch
from
a2e09b3
to
100e01e
Compare
pkosiec
reviewed
Nov 6, 2019
components/director/hack/plugins/descriptionsdecorator/plugin.go
Outdated
Show resolved
Hide resolved
pkosiec
reviewed
Nov 7, 2019
components/director/hack/plugins/descriptionsdecorator/plugin.go
Outdated
Show resolved
Hide resolved
Fix examples prettying Change the example directory structure into subdirectories Turn of description decorator plugin unit tests Apply suggestions from code review Co-Authored-By: Krystian Cieślik <3641496+crabtree@users.noreply.github.com> Fix most of the issues mentioned in the cr mend Add more fixes for the cr Fix const names
kjaksik
force-pushed
the
generating-static-doc
branch
from
3c04d90
to
290f32e
Compare
crabtree
approved these changes
Nov 8, 2019
components/director/hack/plugins/descriptionsdecorator/plugin.go
Outdated
Show resolved
Hide resolved
| expected, err := ioutil.ReadFile("testdata/expected.graphql") | ||
| require.NoError(t, err) | ||
| assert.Equal(t, string(expected), string(actual)) | ||
| err = os.Remove(testOutputFile) |
There was a problem hiding this comment.
You should defer this call right after the file is created (I assume after line 25).
pkosiec
approved these changes
Nov 8, 2019
| func TestMutateConfig(t *testing.T) { | ||
| // GIVEN | ||
|
|
||
| t.Run("Succes", func(t *testing.T) { |
pkosiec
changed the title
DimitarPetrov
pushed a commit
to DimitarPetrov/compass
that referenced
this pull request
Aug 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See #105