Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NakWithDelay Message Delivery in JetStream #17102

Merged
merged 21 commits into from
Apr 17, 2023

Conversation

grischperl
Copy link
Contributor

@grischperl grischperl commented Mar 16, 2023

Description
Instead of using an exponential Backoff where the EC does not respond, this PR changes the currently used AckWait (EC also does not respond) to a NakWithDelay.

Changes proposed in this pull request:

  • EC responds with a Nak
  • msg is put back in the queue and waits previously configured time (30sec) until the msg is send again (max. 100 retries)

Related issue(s)

#13697

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit a8c101d
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/643cf83624556600081d1dee
😎 Deploy Preview https://deploy-preview-17102--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 16, 2023
@grischperl
Copy link
Contributor Author

/test all

@grischperl grischperl linked an issue Mar 16, 2023 that may be closed by this pull request
2 tasks
@grischperl
Copy link
Contributor Author

/test all

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2023
@grischperl
Copy link
Contributor Author

/test all

@grischperl grischperl changed the title Backoff first try Exponential Message Delivery Backoff in JetStream Mar 16, 2023
@grischperl
Copy link
Contributor Author

/test all

@grischperl
Copy link
Contributor Author

/test all

@grischperl
Copy link
Contributor Author

/test all

@grischperl
Copy link
Contributor Author

/test all

@grischperl
Copy link
Contributor Author

/test all

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2023
@grischperl
Copy link
Contributor Author

/test all

@grischperl
Copy link
Contributor Author

/retest

@grischperl
Copy link
Contributor Author

Loadtester: 1500 events

  • target eps = ack
  • undelivered = 0
  • nack = 0
  • after loadtest-stop msg are successfully redelivered

@grischperl
Copy link
Contributor Author

/test all

@grischperl
Copy link
Contributor Author

/retest

@grischperl grischperl marked this pull request as ready for review April 6, 2023 16:27
@grischperl grischperl requested a review from a team as a code owner April 6, 2023 16:27
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2023
@grischperl
Copy link
Contributor Author

/retest

2 similar comments
@grischperl
Copy link
Contributor Author

/retest

@grischperl
Copy link
Contributor Author

/retest

@grischperl grischperl changed the title Exponential Message Delivery Backoff in JetStream NakWithDelay Message Delivery in JetStream Apr 14, 2023
@grischperl
Copy link
Contributor Author

/retest

2 similar comments
@grischperl
Copy link
Contributor Author

/retest

@grischperl
Copy link
Contributor Author

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 14, 2023

@grischperl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-gcp-eventing-v1alpha2 837cfd2 link true /test pre-main-kyma-gardener-gcp-eventing-v1alpha2
pull-kyma-crd-governance 4353483 link true /test pull-kyma-crd-governance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 17, 2023
@kyma-bot kyma-bot merged commit fc0292a into kyma-project:main Apr 17, 2023
MichalKalke pushed a commit to MichalKalke/kyma that referenced this pull request Apr 20, 2023
* Backoff first try

* image bump

* add to jetstreamv2

* Remove AckWait

* Fix maxdeliver

* AckWait

* AcKWait

* Remove AckWait

* Exponential BackOff

* NAK msg with delay

* Add AckWait as backup

* Make AckWait 35sec to see which retry is working

* Set AckWait and NakDelay period same
@k15r k15r added the area/eventing Issues or PRs related to eventing label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Exponential Message Delivery Backoff in JetStream dispatcher
4 participants