Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kyma Istio Operator docs #18068

Merged

Conversation

nataliasitko
Copy link
Contributor

Changes proposed in this pull request:

  • Add Kyma Istio Operator's documentation fetched from the istio repo

@nataliasitko nataliasitko requested a review from a team as a code owner August 29, 2023 06:34
@netlify
Copy link

netlify bot commented Aug 29, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9ce46fa

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 9ce46fa
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64f1b2a6d087980008d7c7fd
😎 Deploy Preview https://deploy-preview-18068--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 29, 2023
strekm
strekm previously approved these changes Aug 29, 2023
Copy link
Contributor

@strekm strekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 29, 2023
@nataliasitko nataliasitko requested review from k15r and a team as code owners August 29, 2023 11:51
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 29, 2023
IwonaLanger
IwonaLanger previously approved these changes Aug 30, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 30, 2023
README.md Outdated Show resolved Hide resolved
@@ -6,7 +7,6 @@
* [Observability charts](/05-technical-reference/00-configuration-parameters/obsv-01-configpara-observability.md)
* [Connection with Compass](/05-technical-reference/00-configuration-parameters/ra-01-connection-with-compass.md)
* [Cluster Users chart](/05-technical-reference/00-configuration-parameters/sec-01-cluster-users.md)
* [Istio chart](/05-technical-reference/00-configuration-parameters/smsh-01-istio-chart.md)
* [Istio Resources chart](/05-technical-reference/00-configuration-parameters/smsh-02-istio-resources-chart.md)
* [Kyma Istio Operator](/istio/user/03-technical-reference/configuration-parameters/01-10-istio-controller-parameters.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove it fully as it is not a helm values approach anymore. The new custom resource is already referenced below

@nataliasitko nataliasitko force-pushed the update-kyma-istio-operator-docs branch from aaa5ad7 to b42e430 Compare August 31, 2023 11:00
@nataliasitko nataliasitko force-pushed the update-kyma-istio-operator-docs branch from 90b1482 to 6990958 Compare August 31, 2023 11:16
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 31, 2023
@nataliasitko nataliasitko requested a review from a team as a code owner September 1, 2023 07:18

- The [Istio chart](../../05-technical-reference/00-configuration-parameters/smsh-01-istio-chart.md)
- The [Istio Resources chart](../../05-technical-reference/00-configuration-parameters/smsh-02-istio-resources-chart.md)
This content has been moved to: [What is Istio in Kyma?](https://kyma-project.io/#/istio/user/00-overview/README.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the question mark or the period from here as they render next to each other (?.).

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 1, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Sep 1, 2023

@nataliasitko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kyma-governance 9ce46fa link false /test pull-kyma-governance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 4431059 into kyma-project:main Sep 1, 2023
4 checks passed
@nataliasitko nataliasitko deleted the update-kyma-istio-operator-docs branch September 1, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants