Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit creating oauth2client when eventing-webhook-auth is enabled #18220

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Sep 22, 2023

Description

Changes proposed in this pull request:

  • in case we use an external webhook authentication backend we do not create an ORY based oauth2client

Related issue(s)

@k15r k15r requested a review from a team as a code owner September 22, 2023 12:51
@k15r k15r requested a review from muralov September 22, 2023 12:51
@k15r k15r added the area/eventing Issues or PRs related to eventing label Sep 22, 2023
@netlify
Copy link

netlify bot commented Sep 22, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d8a6c4b

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit d8a6c4b
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/650d8db9e21cfa00088f2ecb
😎 Deploy Preview https://deploy-preview-18220--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2023
@zhoujing2022 zhoujing2022 added this to the 2.19 milestone Sep 22, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 22, 2023
@kyma-bot kyma-bot merged commit efebd02 into kyma-project:main Sep 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants