-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rafter display name #7864
Merged
akucharska
merged 9 commits into
kyma-project:master
from
akucharska:rafter-display-name
Apr 2, 2020
Merged
Rafter display name #7864
akucharska
merged 9 commits into
kyma-project:master
from
akucharska:rafter-display-name
Apr 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akucharska
added
kind/feature
Categorizes issue or PR as related to a new feature.
area/documentation
Issues or PRs related to documentation
labels
Apr 1, 2020
akucharska
requested review from
aerfio,
alexandra-simeonova,
bszwarc,
janmedrek,
kazydek,
klaudiagrz,
m00g3n,
magicmatatjahu,
majakurcius,
hudymi,
mmitoraj,
piotrmsc,
PK85 and
tomekpapiernik
as code owners
April 1, 2020 07:34
🥰 Documentation preview ready! 🥰 Built with commit e99666e https://deploy-preview-7864--kyma-project-docs-preview.netlify.com |
kazydek
reviewed
Apr 1, 2020
Co-Authored-By: Karolina Zydek <karolina.zydek@sap.com>
Co-Authored-By: Karolina Zydek <karolina.zydek@sap.com>
Co-Authored-By: Karolina Zydek <karolina.zydek@sap.com>
Co-Authored-By: Karolina Zydek <karolina.zydek@sap.com>
kazydek
approved these changes
Apr 2, 2020
aerfio
approved these changes
Apr 2, 2020
hudymi
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Issues or PRs related to documentation
kind/feature
Categorizes issue or PR as related to a new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Asset has no readable and unique name. We need it to distinguish different assets in ServiceCatalog UI (tab titles, to be precise).
Please read kyma-project/console#1617 to deeper understand the problem.
Related issue(s)
https://github.com/kyma-project/console/issues/1617
https://github.com/kyma-project/rafter/issues/71