Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Extract filemutex cache #1344

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Conversation

lindnerby
Copy link
Member

Description

Changes proposed in this pull request:

  • Extract the locker caching when manifest parsing
  • Add coverage and tests

Related issue(s)

@lindnerby lindnerby requested a review from a team as a code owner February 26, 2024 06:23
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2024
@lindnerby lindnerby linked an issue Feb 26, 2024 that may be closed by this pull request
3 tasks
@c-pius c-pius self-assigned this Feb 26, 2024
internal/manifest/filemutex/cache.go Outdated Show resolved Hide resolved
internal/manifest/filemutex/cache.go Show resolved Hide resolved
internal/manifest/filemutex/cache_test.go Outdated Show resolved Hide resolved
internal/manifest/filemutex/cache.go Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 27, 2024
@kyma-bot kyma-bot merged commit 6ca2dbc into kyma-project:main Feb 27, 2024
32 of 33 checks passed
@lindnerby lindnerby deleted the extract-filemutex branch February 27, 2024 12:47
@c-pius c-pius added the area/quality Related to all activites around quality label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Related to all activites around quality cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring: Global In-Memory Caches
3 participants