Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reintroduce kyma event filter #1854

Merged
merged 5 commits into from
Sep 11, 2024
Merged

fix: Reintroduce kyma event filter #1854

merged 5 commits into from
Sep 11, 2024

Conversation

lindnerby
Copy link
Member

Description

Changes proposed in this pull request:

  • Re-add event filter for kymas control loop for gen and label change only. Generic events are too spammy and this has been removed accidentally.

Related issue(s)

@lindnerby lindnerby requested a review from a team as a code owner September 11, 2024 06:58
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 11, 2024
@lindnerby lindnerby added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2024
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2024
@lindnerby lindnerby removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 11, 2024
@amritanshusikdar amritanshusikdar merged commit 506706a into kyma-project:main Sep 11, 2024
35 of 36 checks passed
@lindnerby lindnerby deleted the reintroduce-kyma-event-filter branch September 12, 2024 04:59
@c-pius c-pius mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-pius c-pius c-pius approved these changes

@amritanshusikdar amritanshusikdar amritanshusikdar approved these changes

Assignees

@c-pius c-pius

@amritanshusikdar amritanshusikdar

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lindnerby @c-pius @amritanshusikdar @kyma-bot @ruanxin