fix: e2e watcher integration #236

adityabhatia · 2022-10-05T17:30:49Z

No description provided.

…yma-project#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com>

adityabhatia · 2022-10-05T17:36:55Z

/hold

adityabhatia · 2022-10-05T18:48:53Z

As a side comment: CRDs and CRs cannot be a part of the same Kustomize deploy. Eventually it works but a better strategy is required.

kubernetes-sigs/kustomize#3502

customresourcedefinition.apiextensions.k8s.io/kymas.operator.kyma-project.io created
customresourcedefinition.apiextensions.k8s.io/moduletemplates.operator.kyma-project.io created
customresourcedefinition.apiextensions.k8s.io/watchers.operator.kyma-project.io created
serviceaccount/lifecycle-manager-controller-manager created
role.rbac.authorization.k8s.io/lifecycle-manager-leader-election-role created
clusterrole.rbac.authorization.k8s.io/lifecycle-manager-manager-role created
clusterrole.rbac.authorization.k8s.io/lifecycle-manager-manager-role-manifest created
clusterrole.rbac.authorization.k8s.io/lifecycle-manager-metrics-reader created
rolebinding.rbac.authorization.k8s.io/lifecycle-manager-leader-election-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/lifecycle-manager-manager-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/lifecycle-manager-manager-rolebinding-manifest created
clusterrolebinding.rbac.authorization.k8s.io/lifecycle-manager-metrics-rolebinding created
configmap/lifecycle-manager-manager-config created
service/lifecycle-manager-controller-manager-metrics-service created
service/lifecycle-manager-event-service created
deployment.apps/lifecycle-manager-controller-manager created
error: resource mapping not found for name: "lifecycle-manager-watcher" namespace: "kcp-system" from "STDIN": no matches for kind "Watcher" in version "operator.kyma-project.io/v1alpha1"
ensure CRDs are installed first
make: *** [deploy] Error 1

ruanxin · 2022-10-06T08:22:03Z

operator/config/default/kustomization.yaml

@@ -23,7 +23,7 @@ components:
  - ../crd
  - ../rbac
  # [WATCHER] To enable the watcher, uncomment all the sections with [WATCHER]
-  #- ../watcher
+  - ../watcher


watcher should be disabled by default

yes I am aware this for the reviewer to check

anyways the Kustomize build has to be fixed

ruanxin · 2022-10-06T08:22:33Z

operator/config/default/kustomization.yaml

@@ -23,7 +23,7 @@ components:
  - ../crd
  - ../rbac
  # [WATCHER] To enable the watcher, uncomment all the sections with [WATCHER]
-  #- ../watcher
+  - ../watcher


Suggested change

- ../watcher

#- ../watcher

ruanxin · 2022-10-06T08:34:50Z

operator/config/watcher/kustomization.yaml

+        value: --requeue-failure-interval=5m
+      - op: add
+        path: /spec/template/spec/containers/0/args/-
+        value: --kcp-addr=34.76.239.193:80


do we have an issue cover this address problem? to reach it from fixed DNS name instead of IP?

Not yet good point. That is a whole another feature implementation. Should not be a part of this PR.

ruanxin · 2022-10-06T08:42:10Z

operator/internal/deploy/webhook_config_test.go

@@ -58,14 +58,14 @@ var _ = Describe("deploy watcher", Ordered, func() {
 	})

 	It("deploys watcher helm chart with correct webhook config", func() {
-		err := deploy.UpdateWebhookConfig(ctx, webhookChartPath, watcherCR, testEnv.Config, k8sClient)
+		err := deploy.UpdateWebhookConfig(ctx, webhookChartPath, watcherCR, testEnv.Config, k8sClient, "")


we should have an explainable variable to the last param, like "fake-ip" instead of empty string.

This will either be a DNS Name or an IP. If DNS Name is not passed, then IP will be calculated from istio ingress service. See upcoming commit.

* refactor and improve docs * connect docs and further refinement * review comments

into fixE2EWatcher

…le-manager into fixE2EWatcher

adityabhatia · 2022-10-06T13:09:53Z

/unhold

* add KCP watcher controller and tests (#224) * add KCP watcher controller and tests Co-authored-by: Xin Ruan <xin.ruan@sap.com> * Dynamically create Virtual Service resource for watcher reconciler (#231) * add KCP watcher controller and tests * refactor and fix tests * further refactoring and fixes * fix Dockerfile and update dependencies * remove skipped tests * refactor tests * add watcher crd and fix module info state * fix tests and lint issues * - update Dockerfile * - add missing watcher.yaml * - update watcher yaml * - update gomod * add args enable-kcp-watcher patch * create virtual service resource if it doesn't exist * clean up virtual service vars and params * apply review suggestions * change contract version from 1 to v1 Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> Co-authored-by: Xin Ruan <xin.ruan@sap.com> * fix: e2e watcher integration (#236) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: e2e watcher integration * further fixes * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * dyncmic ingress external IP Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: remove virtual service (#239) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: e2e watcher integration * further fixes * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * dyncmic ingress external IP * remote virtual service * fix: secret gen for kyma (#240) Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * Dynamic Informers watches manifest instead of all resources (#244) * - add patch for gateway namespace - remove VirtualService - watches manifest instead of all resources under operator group * let dynamic informers to only watch manifest * remove patch comment * remove redundant array init * Fix watcher bugs for load test (#246) * ignore go.work files * fix virtual service deletion bug * rm unused method * fix watcher false ready state * make helm value overwrite working * fix loadbalancer creation and update * fix gateway error * fix: failing logic and tests Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> * fix: merge conflicts for add_watcher (#252) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * fix: secret gen for kyma (#240) * Advance the Documentation of local setup (#248) * Fixed some links in readme doc * Added missing doc stuff Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com> * fix: merge conflicts for load_test (#253) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * fix: secret gen for kyma (#240) * Advance the Documentation of local setup (#248) * Fixed some links in readme doc * Added missing doc stuff * docs: add contents and other minor fixes (#250) * fix: failing watcher tests and minor refactoring * comment out watcher Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com> * Adjust watcher for load test (#254) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * fix: secret gen for kyma (#240) * Advance the Documentation of local setup (#248) * Fixed some links in readme doc * Added missing doc stuff * docs: add contents and other minor fixes (#250) * patch for load test * adjust reconciler interval add istio sidecar Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com> Co-authored-by: Ali Khlifi <46890720+khlifi411@users.noreply.github.com> Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com>

* add KCP watcher controller and tests (#224) * add KCP watcher controller and tests Co-authored-by: Xin Ruan <xin.ruan@sap.com> * Dynamically create Virtual Service resource for watcher reconciler (#231) * add KCP watcher controller and tests * refactor and fix tests * further refactoring and fixes * fix Dockerfile and update dependencies * remove skipped tests * refactor tests * add watcher crd and fix module info state * fix tests and lint issues * - update Dockerfile * - add missing watcher.yaml * - update watcher yaml * - update gomod * add args enable-kcp-watcher patch * create virtual service resource if it doesn't exist * clean up virtual service vars and params * apply review suggestions * change contract version from 1 to v1 Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> Co-authored-by: Xin Ruan <xin.ruan@sap.com> * fix: e2e watcher integration (#236) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: e2e watcher integration * further fixes * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * dyncmic ingress external IP Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: remove virtual service (#239) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: e2e watcher integration * further fixes * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * dyncmic ingress external IP * remote virtual service * fix: secret gen for kyma (#240) Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * Dynamic Informers watches manifest instead of all resources (#244) * - add patch for gateway namespace - remove VirtualService - watches manifest instead of all resources under operator group * let dynamic informers to only watch manifest * remove patch comment * remove redundant array init * Fix watcher bugs for load test (#246) * ignore go.work files * fix virtual service deletion bug * rm unused method * fix watcher false ready state * make helm value overwrite working * fix loadbalancer creation and update * fix gateway error * fix: failing logic and tests Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> * fix: merge conflicts for add_watcher (#252) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * fix: secret gen for kyma (#240) * Advance the Documentation of local setup (#248) * Fixed some links in readme doc * Added missing doc stuff Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com> * patch for load test * adjust reconciler interval add istio sidecar * - add v1 path to AuthorizationPolicy - remove gateway - enable namespace istio injection - * disable watcher in default * remove unnecessary patch * bring back gateway * rename gateway for kcp Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> Co-authored-by: Ali Khlifi <46890720+khlifi411@users.noreply.github.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com>

* add KCP watcher controller and tests (#224) * add KCP watcher controller and tests Co-authored-by: Xin Ruan <xin.ruan@sap.com> * Dynamically create Virtual Service resource for watcher reconciler (#231) * add KCP watcher controller and tests * refactor and fix tests * further refactoring and fixes * fix Dockerfile and update dependencies * remove skipped tests * refactor tests * add watcher crd and fix module info state * fix tests and lint issues * - update Dockerfile * - add missing watcher.yaml * - update watcher yaml * - update gomod * add args enable-kcp-watcher patch * create virtual service resource if it doesn't exist * clean up virtual service vars and params * apply review suggestions * change contract version from 1 to v1 Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> Co-authored-by: Xin Ruan <xin.ruan@sap.com> * fix: e2e watcher integration (#236) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: e2e watcher integration * further fixes * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * dyncmic ingress external IP Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: remove virtual service (#239) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: e2e watcher integration * further fixes * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * dyncmic ingress external IP * remote virtual service * fix: secret gen for kyma (#240) Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * Dynamic Informers watches manifest instead of all resources (#244) * - add patch for gateway namespace - remove VirtualService - watches manifest instead of all resources under operator group * let dynamic informers to only watch manifest * remove patch comment * remove redundant array init * Fix watcher bugs for load test (#246) * ignore go.work files * fix virtual service deletion bug * rm unused method * fix watcher false ready state * make helm value overwrite working * fix loadbalancer creation and update * fix gateway error * fix: failing logic and tests Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> * fix: merge conflicts for add_watcher (#252) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * fix: secret gen for kyma (#240) * Advance the Documentation of local setup (#248) * Fixed some links in readme doc * Added missing doc stuff Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com> * patch for load test * adjust reconciler interval add istio sidecar * - add v1 path to AuthorizationPolicy - remove gateway - enable namespace istio injection - * disable watcher in default * remove unnecessary patch * bring back gateway * rename gateway for kcp * overwrite SkrWebhookMemoryLimits and SkrWebhookCPULimits * disable catalog sync for load test * add watcher patch * add missing config Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> Co-authored-by: Ali Khlifi <46890720+khlifi411@users.noreply.github.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com>

* add KCP watcher controller and tests (#224) * add KCP watcher controller and tests Co-authored-by: Xin Ruan <xin.ruan@sap.com> * Dynamically create Virtual Service resource for watcher reconciler (#231) * add KCP watcher controller and tests * refactor and fix tests * further refactoring and fixes * fix Dockerfile and update dependencies * remove skipped tests * refactor tests * add watcher crd and fix module info state * fix tests and lint issues * - update Dockerfile * - add missing watcher.yaml * - update watcher yaml * - update gomod * add args enable-kcp-watcher patch * create virtual service resource if it doesn't exist * clean up virtual service vars and params * apply review suggestions * change contract version from 1 to v1 Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> Co-authored-by: Xin Ruan <xin.ruan@sap.com> * fix: e2e watcher integration (#236) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: e2e watcher integration * further fixes * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * dyncmic ingress external IP Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: remove virtual service (#239) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * fix: e2e watcher integration * further fixes * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * dyncmic ingress external IP * remote virtual service * fix: secret gen for kyma (#240) Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * Dynamic Informers watches manifest instead of all resources (#244) * - add patch for gateway namespace - remove VirtualService - watches manifest instead of all resources under operator group * let dynamic informers to only watch manifest * remove patch comment * remove redundant array init * Fix watcher bugs for load test (#246) * ignore go.work files * fix virtual service deletion bug * rm unused method * fix watcher false ready state * make helm value overwrite working * fix loadbalancer creation and update * fix gateway error * fix: failing logic and tests Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> * fix: merge conflicts for add_watcher (#252) * Refactor load_test as dedicate kustomize build instead of component (#232) * refactor load_test as dedicate kustomize build * remove load-test-deploy command * Update operator/config/load_test/kustomization.yaml Co-authored-by: Xin Ruan <ruanxin1@gmail.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * docs: refactor and improve environment setup (#219) * refactor and improve docs * connect docs and further refinement * review comments * fix: secret gen for kyma (#240) * Advance the Documentation of local setup (#248) * Fixed some links in readme doc * Added missing doc stuff Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com> * patch for load test * adjust reconciler interval add istio sidecar * - add v1 path to AuthorizationPolicy - remove gateway - enable namespace istio injection - * disable watcher in default * remove unnecessary patch * bring back gateway * rename gateway for kcp * overwrite SkrWebhookMemoryLimits and SkrWebhookCPULimits * disable catalog sync for load test * add watcher patch * add missing config * replace path with patch Co-authored-by: Aditya Bhatia <aditya.bhatia@sap.com> Co-authored-by: Ali Khlifi <46890720+khlifi411@users.noreply.github.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com>

kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2022

adityabhatia force-pushed the fixE2EWatcher branch from 52084f2 to 856bec2 Compare October 5, 2022 17:34

adityabhatia changed the base branch from add_watcher to main October 5, 2022 17:36

kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 5, 2022

kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022

adityabhatia force-pushed the fixE2EWatcher branch from 856bec2 to 2cc439e Compare October 5, 2022 17:43

fix: e2e watcher integration

c1cd027

adityabhatia force-pushed the fixE2EWatcher branch from 2cc439e to c1cd027 Compare October 5, 2022 17:52

adityabhatia mentioned this pull request Oct 5, 2022

Error on updating remote kyma CR via watcher event #237

Closed

adityabhatia requested review from ruanxin and fourthisle October 5, 2022 19:13

further fixes

9af547c

adityabhatia force-pushed the fixE2EWatcher branch from 03644c0 to 9af547c Compare October 5, 2022 19:15

ruanxin changed the base branch from main to add_watcher October 6, 2022 08:21

kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 6, 2022

ruanxin reviewed Oct 6, 2022

View reviewed changes

adityabhatia added 3 commits October 6, 2022 13:04

docs: refactor and improve environment setup (kyma-project#219)

dd651c6

* refactor and improve docs * connect docs and further refinement * review comments

dyncmic ingress external IP

4d67d78

Merge branch 'main' of https://github.com/kyma-project/lifecycle-manager

27db5cb

into fixE2EWatcher

kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2022

Merge branch 'add_watcher' of https://github.com/kyma-project/lifecyc…

5aed616

…le-manager into fixE2EWatcher

adityabhatia force-pushed the fixE2EWatcher branch from aee0717 to 5aed616 Compare October 6, 2022 12:59

ruanxin approved these changes Oct 6, 2022

View reviewed changes

kyma-bot assigned ruanxin Oct 6, 2022

kyma-bot added the lgtm Looks good to me! label Oct 6, 2022

kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2022

kyma-bot merged commit 0539106 into kyma-project:add_watcher Oct 6, 2022

adityabhatia linked an issue Oct 6, 2022 that may be closed by this pull request

Fix existing bugs to enable load testing #228

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: e2e watcher integration #236

fix: e2e watcher integration #236

adityabhatia commented Oct 5, 2022

adityabhatia commented Oct 5, 2022

adityabhatia commented Oct 5, 2022 •

edited

Loading

ruanxin Oct 6, 2022

adityabhatia Oct 6, 2022

adityabhatia Oct 6, 2022

ruanxin Oct 6, 2022

ruanxin Oct 6, 2022

adityabhatia Oct 6, 2022

ruanxin Oct 6, 2022

adityabhatia Oct 6, 2022

adityabhatia commented Oct 6, 2022

fix: e2e watcher integration #236

fix: e2e watcher integration #236

Conversation

adityabhatia commented Oct 5, 2022

adityabhatia commented Oct 5, 2022

adityabhatia commented Oct 5, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adityabhatia commented Oct 6, 2022

adityabhatia commented Oct 5, 2022 •

edited

Loading