This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
refactor: Adjustments for KCP watcher and load tests #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ruanxin
commented
Oct 10, 2022
•
ruanxin
commented
- enable istio sidecar injection
- AuthorizationPolicy add path
- remove gateway
- remove virtual service
# Conflicts: # operator/pkg/manifest/operations.go
# Conflicts: # operator/pkg/manifest/operations.go
# Conflicts: # operator/internal/pkg/custom/verify.go
- AuthorizationPolicy add path - remove gateway - remove virtual service
kyma-bot
added
the
size/L
kyma-bot
added
the
do-not-merge/work-in-progress
ruanxin
commented
Oct 10, 2022
kyma-bot
removed
the
do-not-merge/work-in-progress
adityabhatia
changed the title
| @@ -39,7 +39,7 @@ func (r *Resource) CheckFn(ctx context.Context, manifestObj *unstructured.Unstru | |||
| } | |||
|
|
|||
| ready, err := customStatus.WaitForCustomResources(ctx, resource) | |||
| if err != nil { | |||
| if client.IgnoreNotFound(err) != nil { | |||
There was a problem hiding this comment.
is there a reason for doing this?
There was a problem hiding this comment.
oh, it's changes in my load test setup, should not be here, I reverted it. thanks for pointing out.
adityabhatia
approved these changes
Oct 10, 2022
27 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.