Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by renews #653

Open
oraclenut opened this issue Jan 14, 2024 · 3 comments
Open

Sort by renews #653

oraclenut opened this issue Jan 14, 2024 · 3 comments

Comments

@oraclenut
Copy link

Howdy, thank you for supporting this wallet. I have a lot of names and my issue is that trying to view which ones need to be renewed is painstaking difficult. Request that a "Renew All" or "Renew Oldest" or even sort by ones that need to be renewed.
thank you

@d0peman
Copy link

d0peman commented Feb 23, 2024

I suggested bulk and automatic renews about 2 years ago at Handycon and it seemed to fall on deaf ears at the time.

I personally think it's a pretty crucial feature for a better overall user experience with Handshake in general. Especially if we want to move away from being tied to Namebase and truly decentralise name ownership and management going forward. I'd like to move away from Namebase and use bob-wallet but it's not something I want to have to struggle to use when managing a lot of names; I'd rather focus on developing other things.

It really would be nice to have an auto-renew toggle for each name as well as an option to set this for all names. Probably with a warning to the user that the mining fee will change with a link to information regarding this. I'd be happy to provide more feedback if needed

@rithvikvibhu
Copy link
Collaborator

I agree a better way to see expiring names would be nice. And being able to bulk renew a few selected names is coming as part of

Auto renews on the other hand is different and hasn't been done for a few reasons:

  • Renew transactions can't just be signed beforehand and given to a watchtower (like you can technically do with scheduling reveals for bids). This is because a renew tx must include info from a "recent" block to prove that it wasn't signed months ago. That's also why it's not possible to presign and stack 10 years worth of renews at once.
  • Signing a tx requires the wallet to be unlocked. Unlocking requires the password. So if auto renew is implemented in Bob, the wallet will need to stay unlocked or at least store the password somewhere, which isn't a great idea.
  • Unlike naming systems based on smart contracts, it's not possible delegate some access to others - so we can't just say "let hs1... / kyokan renew this name on my behalf". Only the wallet owning the name can do renew. Maybe with Split domain management handshake-org/hsd#651 there might be something we can do, but it's still not ideal, all names would have to be on a script.
  • And even after all this, if Bob adds an auto renew, it will need to stay open and synced all the time to be of any use. Which isn't what most people do. They check in every couple of days/weeks/months to use the wallet and close it. And if they are opening Bob, the renew option shows up for names expiring in the next 3 months. One-click renew is the closest feasible option right now.

So there's just a lot to consider for auto renewals in self-custody solutions (custody is easy since the service stays online and controls all the names).

@webelity
Copy link

Will #631 be merged into the next version? It would be an extremely handy feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants