Split domain management #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTX clone() would not carry over coinview, in order to get around this the CoinSelector would remove all inputs and add them back which made working with partially signed transactions a pain, this should fix that issue.
Previous version of interactive-name-swap used a ugly hack to get around limitations on wallet funding, since wallet.fund() no longer wipes previous inputs, the previous implementation is not longer the recommended way.
Pull Request Test Coverage Report for Build 1391888710
💛 - Coveralls |
Anunayj
force-pushed
the
split-domain-management
branch
2 times, most recently
from
79bde70
to
eecf36f
Compare
Example script to have seperate keys for UPDATEing and TRANSFERing domains + anyone can renew Co-authored-by: Matthew Zipkin <pinheadmz@gmail.com>
Anunayj
force-pushed
the
split-domain-management
branch
from
eecf36f
to
723c014
Compare
Anunayj
added
tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test should document how script addresses can be used to allow different entities to RENEW, UPDATE, and retain ownership of the domain without sharing keys.
This way watchtowers can be deployed whose sole purpose is to renew the domain, and have the ability to have a separate key for UPDATE(ing) DNS records on chain. While having a Cold Wallet (or Multisig) for the actual ownership/transfers.
HIP-0009 (handshake-org/HIPs#40) needs to be discussed to standardize how to derive the keys used for this.
This (branches from and) depends on PR #639 to be merged.