Fix crash on setblock #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no issue made about this, but it crashes on setblock (For example, the_aether:blue_portal when there is no glowstone below it). Previously to this update, a StackOverflowError would occur. Now, it will stop looping when the Y value is below zero, since there are no more blocks below and thus no reason to continue looping into the void.
kyrptonaught
added a commit
that referenced
this pull request
Apr 17, 2021
…ck-Papel). Also makes CustomPortalBlock:getPortalBase non-static, allowing custom portal blocks to overwrite its logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no issue made about this, but before these changes, the game would crash on /setblock (For example, /setblock ~ ~ ~ the_aether:blue_portal would crash when there was no glowstone below it). Prior to this update, a StackOverflowError would occur. Now, getPortalBase() will stop looping when the Y value of the block being searched is below zero, since there are no more blocks below and thus no reason to continue looping into the void.