Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some suggestions for strict validations #3

Merged
merged 4 commits into from
Apr 2, 2013
Merged

Some suggestions for strict validations #3

merged 4 commits into from
Apr 2, 2013

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Apr 2, 2013

No description provided.

@kachick
HSLRGB::RGB: Add specs for ::valid_rgb?
337036d
@kachick
HSLRGB::RGB: Fix ::valid_rgb? for more strictly
cdf67a6 
NOTE: Range#include? depends element#succ on Ruby1.9+ for many objects.
      ::byte? checks Integer. And Range#cover? is more clealy at here.
@kachick
HSLRGB::HSL: Add specs for ::valid_hsl?
984c2e3
@kachick
HSLRGB::HSL: Fix ::valid_hsl? for more strictly
5224c64
kyrylo added a commit that referenced this pull request Apr 2, 2013
@kyrylo
Merge pull request #3 from kachick/improve-strictly-validations
0e237b6 
Some suggestions for strict validations
@kyrylo kyrylo merged commit 0e237b6 into kyrylo:master Apr 2, 2013
@kachick
Copy link
Contributor Author

kachick commented Apr 2, 2013

Thank you!

@kachick kachick deleted the improve-strictly-validations branch April 2, 2013 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kachick @kyrylo