Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Height is not being verified for electrumx peers #152

Closed
shsmith opened this issue Mar 19, 2017 · 0 comments
Closed

Height is not being verified for electrumx peers #152

shsmith opened this issue Mar 19, 2017 · 0 comments

Comments

@shsmith
Copy link
Contributor

shsmith commented Mar 19, 2017

We verify height is within 5 blocks for legacy peers, but this test is skipped for electrumx peers.
This leads to the possibility of an electrumx peer with a deamon on a different chain being included in the peers.
I think it is prudent to verify block height for all peers.
@shsmith shsmith mentioned this issue Mar 19, 2017
Closed
kevacoin-project pushed a commit to kevacoin-project/electrumx that referenced this issue Feb 27, 2022
@ecdsa
Merge pull request kyuupichan#152 from evil-maid/patch-5
b3ae5ab 
Update index.rst - small grammar fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix https://github.com/kyuupichan/electrumx/issues/152 shsmith/electrumx
1 participant
@shsmith