Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estimatefee on Bitcoin Cash #845

Closed
david4neblio opened this issue Jun 23, 2019 · 2 comments
Closed

estimatefee on Bitcoin Cash #845

david4neblio opened this issue Jun 23, 2019 · 2 comments

Comments

@david4neblio
Copy link

david4neblio commented Jun 23, 2019

See #788 for reference.

Bitcoin Cash has removed estimatesmartfee (https://github.com/Bitcoin-ABC/bitcoin-abc/blob/master/doc/release-notes/release-notes-0.17.2.md)

Bitcoin Cash still has estimatefee but returns error upon being provided arguments. It requests calling estimatefee without arguments. ElectrumX protocol requires blockchain.estimatefee to have arguments.

Based on this code in the codebase:

    async def estimatefee(self, block_count):
        '''Return the fee estimate for the block count.  Units are whole
        currency units per KB, e.g. 0.00000995, or -1 if no estimate
        is available.
        '''
        args = (block_count, )
        if await self._is_rpc_available('estimatesmartfee'):
            estimate = await self._send_single('estimatesmartfee', args)
            return estimate.get('feerate', -1)
return await self._send_single('estimatefee', args)

Although the Electrum server will default to estimatefee if estimatesmartfee doesn't exist, it is not possible to call estimatefee without an argument.

@kyuupichan
Copy link
Owner

This doesn't seem to be reflected in the Electron-Cash/electrumx fork the ABC guys maintain. When they implement it I will too. Otherwise a PR is welcome.

rayspock pushed a commit to rayspock/electrumx that referenced this issue Jul 4, 2019
rayspock pushed a commit to rayspock/electrumx that referenced this issue Nov 20, 2019
@kyuupichan
Copy link
Owner

Closing owing to apparent lack of interest, either here or in ElectronX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants