Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing estimate_mode to estimatefee #1001

Merged
merged 5 commits into from
May 27, 2020
Merged

allow passing estimate_mode to estimatefee #1001

merged 5 commits into from
May 27, 2020

Conversation

cipig
Copy link
Contributor

@cipig cipig commented May 11, 2020

No description provided.

@SomberNight
Copy link
Contributor

I haven't tested but this LGTM.
Note that these type of changes typically involve bumping the protocol version and a mention in the docs.

@cipig
Copy link
Contributor Author

cipig commented May 11, 2020

it is an optional parameter, so still works if you don't pass it:

(echo '{ "id": 1, "method": "blockchain.estimatefee", "params": ["1"] }'; sleep 0.5) | ncat 95.216.36.138 10000
{"jsonrpc": "2.0", "result": 0.00059318, "id": 1}

(echo '{ "id": 1, "method": "blockchain.estimatefee", "params": ["1","ECONOMICAL"] }'; sleep 0.5) | ncat 95.216.36.138 10000
{"jsonrpc": "2.0", "result": 0.00022116, "id": 1}

@kyuupichan
Copy link
Owner

Requires doc update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants