Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabsListManager refactor to have use cases #72

Merged
merged 26 commits into from
Feb 4, 2024
Merged

TabsListManager refactor to have use cases #72

merged 26 commits into from
Feb 4, 2024

Commits on Jan 4, 2024

  1. Start work on tabs use cases to not have one big tabs list manager wh… 

    …ich is actually looks more like a data service partly. Also need to think how to separate observers from the use cases
    @kyzmitch
    kyzmitch committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    5eeec74 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Finish ReadTabUseCase and UseCaseFactory, add service commands to Tab… 

    …sDataService
    @kyzmitch
    kyzmitch committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    086b314 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Integrate more use cases and create new view models to leverage them

    @kyzmitch
    kyzmitch committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    d172b57 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Fix compilation

    @kyzmitch
    kyzmitch committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    54cb79b View commit details
    Browse the repository at this point in the history

  2. Fix compilation of CoreBrowser tests

    @kyzmitch
    kyzmitch committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d31acab View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Fix use case locator crash

    @kyzmitch
    kyzmitch committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    226c23f View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Combine last 4 commits

    @kyzmitch
    kyzmitch committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    de9aad9 View commit details
    Browse the repository at this point in the history

  2. Solve complex use case type registration issue

    @kyzmitch
    kyzmitch committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    2417964 View commit details
    Browse the repository at this point in the history

  3. Rename use case classes

    @kyzmitch
    kyzmitch committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    5e05ca3 View commit details
    Browse the repository at this point in the history

  4. Doc comments, attempt to fix SwiftUI site loading (web view model cre… 

    …ation)
    @kyzmitch
    kyzmitch committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    92538ee View commit details
    Browse the repository at this point in the history

  5. Attempt to fix web view model creation

    @kyzmitch
    kyzmitch committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    9466041 View commit details
    Browse the repository at this point in the history

  6. Create web view model without a specific site to solve the async init… 

    … issue
    @kyzmitch
    kyzmitch committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    f2cc716 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Use different approach to be able to store VM as a state object

    @kyzmitch
    kyzmitch committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2a276f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Use environment object to make the constructors smaller, also use nor… 

    …mal search suggestions VM
    @kyzmitch
    kyzmitch committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d2d4000 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Merge branch 'master' into feature/ios_tabs_use_cases 

    # Conflicts:
#	catowseriOS/CottonData/SearchViewModel/Autocomplete/WebSearchAutocomplete+AsyncAwait.swift
#	catowseriOS/CottonData/WebViewModel/DNSResolving/DNSResolver+AsyncAwait.swift
#	catowseriOS/catowser.xcodeproj/project.pbxproj
#	catowseriOS/catowser/BrowserContent/BrowserContentPreview.swift
#	catowseriOS/catowser/BrowserContent/WebView/WebViewModelV2.swift
#	catowseriOS/catowser/Extensions/TabsListManager+Extension.swift
    @kyzmitch
    kyzmitch committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    7091f08 View commit details
    Browse the repository at this point in the history

  2. Update copyright header for the new files from this PR

    @kyzmitch
    kyzmitch committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    6ca4683 View commit details
    Browse the repository at this point in the history

  3. Fix content type reloading to the default one from the async task in … 

    …Phone layout. Fix web view model state by not calling load method if the initial state was pendingLoad in SwiftUI mode. Use Actor protocol for some interfaces which are only used by the actor. Logging.
    @kyzmitch
    kyzmitch committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    78fab7c View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Add mocks auto-generation for the use cases, currently primary associ… 

    …ated type is not supported by the SwiftMocky current version
    @kyzmitch
    kyzmitch committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    b1f9b06 View commit details
    Browse the repository at this point in the history

  2. Fix search suggestions vm tests compilation after adding use case

    @kyzmitch
    kyzmitch committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    d62d8e3 View commit details
    Browse the repository at this point in the history

  3. Fix CottonData unit tests compilation

    @kyzmitch
    kyzmitch committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    d010483 View commit details
    Browse the repository at this point in the history

  4. Fix search suggestions view model tests

    @kyzmitch
    kyzmitch committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    7b87eaf View commit details
    Browse the repository at this point in the history

  5. Fix web view model tests

    @kyzmitch
    kyzmitch committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    22260d7 View commit details
    Browse the repository at this point in the history

  6. Fix client compilation

    @kyzmitch
    kyzmitch committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    6fc99b3 View commit details
    Browse the repository at this point in the history

  7. fix linter

    @kyzmitch
    kyzmitch committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    f17ea9c View commit details
    Browse the repository at this point in the history

  8. Swiftlint format result

    @kyzmitch
    kyzmitch committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    14858f4 View commit details
    Browse the repository at this point in the history

  9. Fix lint errors for sure

    @kyzmitch
    kyzmitch committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    0d9dedc View commit details
    Browse the repository at this point in the history