Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include promotions in Qsearch #97

Merged
merged 8 commits into from
Dec 28, 2022
Merged

Include promotions in Qsearch #97

merged 8 commits into from
Dec 28, 2022

Conversation

PGG106
Copy link
Contributor

@PGG106 PGG106 commented Dec 22, 2022 •
edited
Loading 

ELO   | 5.97 +- 4.56 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=64MB
LLR   | 2.97 (-2.94, 2.94) [0.00, 5.00]
GAMES | N: 12864 W: 3828 L: 3607 D: 5429

6/14

gcp
gcp reviewed Dec 23, 2022
View reviewed changes
src/main.cpp Outdated
@@ -316,8 +316,9 @@ void generate_piece_moves(Move *const movelist,
const BB all = pos.colour[0] | pos.colour[1];
const BB to_mask = only_captures ? pos.colour[1] : ~pos.colour[0];
const BB pawns = pos.colour[0] & pos.pieces[Pawn];
generate_pawn_moves(
movelist, num_moves, north(pawns) & ~all & (only_captures ? 0xFF00000000000000ULL : 0xFFFFFFFFFFFF0000ULL), -8);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second mask can be written more compact as ~0.

Copy link
Contributor Author

@PGG106 PGG106 Dec 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was looking for a way to have a more compact mask and i couldn't find one, thank you
edit: i've been informed that the compressed size doesn't change and to leave the mask as is

gcp added a commit to gcp/4ku that referenced this pull request Dec 23, 2022
@gcp
Amalgamate most outstanding strength patches.
90143ba 
To make it easier to make the tournament deadline.

* Bad bishop eval (kz04px#56).
* Late move pruning changes (kz04px#78).
* Improving variable (kz04px#83).
* Include promotions in qsearch (kz04px#97).
gcp added a commit to gcp/4ku that referenced this pull request Dec 23, 2022
@gcp
Amalgamate most outstanding strength patches.
e277658 
To make it easier to make the tournament deadline.

* Bad bishop eval (kz04px#56).
* Late move pruning changes (kz04px#78).
* Improving variable (kz04px#83).
* Include promotions in qsearch (kz04px#97).
gcp added a commit to gcp/4ku that referenced this pull request Dec 23, 2022
@gcp
Amalgamate most outstanding strength patches.
1c38074 
To make it easier to make the tournament deadline.

* Bad bishop eval (kz04px#56).
* Late move pruning changes (kz04px#78).
* Improving variable (kz04px#83).
* Include promotions in qsearch (kz04px#97).

Also include kz04px#95 to make this exactly 4096 bytes,
and put in tournament settings (hash/threads) that
keep the size at exactly that.

vs master (432c06a):

ELO   | 18.58 +- 9.34 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=64MB
LLR   | 2.97 (-2.94, 2.94) [0.00, 5.00]
GAMES | N: 3032 W: 945 L: 783 D: 1304
@gcp gcp mentioned this pull request Dec 23, 2022
Closed
gcp added a commit to gcp/4ku that referenced this pull request Dec 23, 2022
@gcp
Amalgamate most outstanding strength patches.
697d065 
To make it easier to make the tournament deadline.

* Bad bishop eval (kz04px#56).
* Late move pruning changes (kz04px#78).
* Improving variable (kz04px#83).
* Include promotions in qsearch (kz04px#97).

Also include kz04px#95 to make this exactly 4096 bytes,
and put in tournament settings (hash/threads) that
keep the size at exactly that.

vs master (432c06a):

ELO   | 18.58 +- 9.34 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=64MB
LLR   | 2.97 (-2.94, 2.94) [0.00, 5.00]
GAMES | N: 3032 W: 945 L: 783 D: 1304
gcp added a commit to gcp/4ku that referenced this pull request Dec 23, 2022
@gcp
Amalgamate most outstanding strength patches.
6969225 
To make it easier to make the tournament deadline.

* Bad bishop eval (kz04px#56).
* Late move pruning changes (kz04px#78).
* Improving variable (kz04px#83).
* Include promotions in qsearch (kz04px#97).

Also include kz04px#95 to make this exactly 4096 bytes,
and put in tournament settings (hash/threads) that
keep the size below target.

vs master (432c06a):

ELO   | 18.58 +- 9.34 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=64MB
LLR   | 2.97 (-2.94, 2.94) [0.00, 5.00]
GAMES | N: 3032 W: 945 L: 783 D: 1304
@gcp
Copy link
Contributor

gcp commented Dec 28, 2022

With the current minifier and some fiddling with the masks this is down to 6 bytes, retesting strength now.

gcp added a commit to gcp/4ku that referenced this pull request Dec 28, 2022
@gcp
Promotions in qsearch.
7fb09b2 
Rebase of kz04px#97 by PGG106, with constants tweaked to please the current
minfier and get it down to 6 bytes.

Score of 4ku vs master: 3413 - 3215 - 6226  [0.508] 12854
...      4ku playing White: 1855 - 1388 - 3185  [0.536] 6428
...      4ku playing Black: 1558 - 1827 - 3041  [0.479] 6426
...      White vs Black: 3682 - 2946 - 6226  [0.529] 12854
Elo difference: 5.4 +/- 4.3, LOS: 99.2 %, DrawRatio: 48.4 %
SPRT: llr 2.95 (100.0%), lbound -2.94, ubound 2.94 - H1 was accepted
@gcp gcp mentioned this pull request Dec 28, 2022
Closed
@gcp
Copy link
Contributor

gcp commented Dec 28, 2022

I put up my rebase+tweak in another pull.

@PGG106
Copy link
Contributor Author

PGG106 commented Dec 28, 2022

yeah the change actually saves space, my bad for trusting twipply and not doing this before

@kz04px kz04px merged commit a3d98e9 into kz04px:master Dec 28, 2022
@kz04px
Copy link
Owner

kz04px commented Dec 28, 2022

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcp gcp gcp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PGG106 @gcp @kz04px