Made hmac signature source more flexible with an additional optional parameter. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Jeb/EC] Added lein 2 support, added optional function param to get hmac...
kzar
added a commit
that referenced
this pull request
Jun 4, 2013
Made hmac signature source more flexible with an additional optional parameter.
|
Thanks Jeb! |
|
Thank you Dave. You up for bumping the version to 0.2.0 and pushing to On Tue, Jun 4, 2013 at 3:05 PM, Dave Barker notifications@github.comwrote:
Jeb Beich |
|
Yea I'm way ahead... well kind of ahead of you! I had to stop for dinner and sort out GPG keys and such, should be up soon. |
|
Thanks again, Dave. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Dave, we kicked around a few implementations and this looked like the simplest non-breaking change that would get the job done. Also have included a few new tests.