-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kk/auto generate api reference #135
Conversation
|
be809ff
to
2a7446a
Compare
92273b8
to
bd9e4fe
Compare
@krzkaczor could you take a look at this? There's still the case of encoding special characters, but it's some progress. I'll test it more thoroughly tomorrow morning, but I suppose it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress! Still, there is some work to do on the readability of the output (see images, the former is so much easier to skim) but definitely, we are getting closer!
One note is that I think we will need to add a little bit of handcrafted configuration to the generator. For example not
is a modifier, not a validator, and should be listed as such.
69befa8
to
fc9fea1
Compare
429e1c8
to
c40414c
Compare
We've reached the limit of parsing files by regex — I added a few hacks to make the API reference look good. I'm unhappy with it, but I suppose it's fine for now. |
f72d20f
to
1948d94
Compare
@krzkaczor I deployed this branch here: https://earljs-docs-hasparus1.vercel.app/docs/api/api-reference |
bf93cd1
to
8a52bb8
Compare
8a52bb8
to
2cc004a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFG! I love how the new api reference reads.
I am not 100% sure if I like how matchers and validators got split up to different files - now implementation is in one file and docs in another :/ I have strong header files vibes. But I don't see an easy, better solution.
"build": "wsrun -temc build", | ||
"build:noweb": "wsrun -x website -temc build", | ||
"build": "wsrun -x website -temc build", | ||
"build:website": "yarn workspace website build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.