Add missing statuses to transaction details #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L2B-998 Show full history in Perpetual Forced Withdrawal page
Make sure to display statuses like "Sent" (when initiated on our explorer) and all other possible states. L2B-996 Display full history in Forced Buy/Sell Details page
Currently we only display two final phases (Mined 4/5 and Included 5/5). Display all previous and all possible statuses. This will require fetching data from multiple DB tables. In cases where the offer was initiated by our explorer, we must display "Sent" status as well. You can consult the legacy explorer on how this can be fetched and displayed. Notes
|
torztomasz
force-pushed
the
add-missing-statuses
branch
from
56250ab
to
1bc3efd
Compare
torztomasz
force-pushed
the
add-missing-statuses
branch
from
1bc3efd
to
3c81252
Compare
torztomasz
force-pushed
the
add-missing-statuses
branch
from
3dc5647
to
4596ad6
Compare
torztomasz
requested review from
adamiak and
sz-piotr
and removed request for
adamiak
Wendrowiec13
approved these changes
Mar 27, 2023
adamiak
approved these changes
Mar 27, 2023
torztomasz
force-pushed
the
add-missing-statuses
branch
from
8e9541d
to
8486eec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-998, L2B-996
This PR aims to implement correct logic for displaying transactions and resolve all TODOs in TransactionController.
Please pay special attention to this and this commit as it may break offers.