Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a transient for interacting with org-fc #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swflint
Copy link

@swflint swflint commented Dec 2, 2023

No description provided.

@swflint swflint force-pushed the add-transient branch 2 times, most recently from fee12a6 to 1d31893 Compare December 2, 2023 22:14
@l3kn
Copy link
Owner

l3kn commented Feb 2, 2024

With the current version of org-fc, there are now three points of the review process audio files can be attached to,
before-setup, after-setup and after-flip.

Do you have a preference on how the key bindings should be changed to include these?

@swflint
Copy link
Author

swflint commented Feb 2, 2024

I'll update the PR, but here's my thought:

  • ab before setup
  • aa after setup
  • af after flip

@l3kn
Copy link
Owner

l3kn commented Feb 2, 2024

Thanks, that seems sensible! Something like "ab" (before everything else), "as" (after setup) and "af" (after flip) might also work.
When editing or writing cards, another audio command I frequently use is org-fc-audio-play which could get a "ap" binding.

Just like with the hydra, users with specific needs or other preferences can use these files as templates for their own implementations so I don't think the details are too important as long as the most common functions are available.

@swflint
Copy link
Author

swflint commented Feb 2, 2024

I like those better, and good idea on adding the play binding. Updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants