Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adaptive height when using layer shell mode #139

Open
Aleksanaa opened this issue Feb 8, 2023 · 4 comments
Open

Add support for adaptive height when using layer shell mode #139

Aleksanaa opened this issue Feb 8, 2023 · 4 comments

Comments

@Aleksanaa
Copy link

Aleksanaa commented Feb 8, 2023

Rofi has a fixed-height: false option to make the height adaptive, which means when typing to search something, the height of the window gets smaller as candidates shrink, leaving no blank space between last candidate and the bottom. Is it possible to also implement this feature in yofi?

@l4l
Copy link
Owner

l4l commented Feb 8, 2023

For the centered window auto-resize implies "jumping" which should be really annoying.

In general it's not really hard to implement and I'd rather prefer height = "auto" instead of separate option.

@Aleksanaa
Copy link
Author

You mean jumping is resizing with no animations? Anyway I'm more annoyed by blank spaces. An implementation in any means would be appreciated.

@l4l
Copy link
Owner

l4l commented Feb 8, 2023

Yeah, instant resizing without animation will look terrible. A possible workaround for this one is to have a fixed window offset (window_offsets option) but it still won't be smooth

@NullVoxPopuli
Copy link

if the top border is fixed, the jumping isn't so bad, and can be smoothed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants