Issue49 #53
Issue49 #53
Conversation
…o in ./flyby, but cat readout of db seems fine...
…Missing yes/no confirmation to overwrite transponder database.
fetch_satnogs_db.py
Outdated
| previous_norad_id = False | ||
|
|
||
| # Iterate through SatNOGS database | ||
| for i in sorteddata: |
There was a problem hiding this comment.
Maybe use something else than i, satellite or something.
There was a problem hiding this comment.
Fixed in commit commit 2c7cf97
Renaming i to transponder
fetch_satnogs_db.py
Outdated
| previous_norad_id = i['norad_cat_id'] | ||
|
|
||
| # Add transponder data | ||
| db.write("%s - Inverting = %r " %(i['description'], i['invert'])) |
There was a problem hiding this comment.
Suggestion: Write "inverting" when inverting = True, but not otherwise.
fetch_satnogs_db.py
Outdated
| if not i['baud']: | ||
| db.write("- Baud = %s " %i['baud']) | ||
| if not i['alive']: | ||
| db.write("Not currently alive\n") |
There was a problem hiding this comment.
Suggestion: Write only "(dead)"
fetch_satnogs_db.py
Outdated
| db.write("No weekly schedule\n") | ||
| db.write("No orbital schedule\n") | ||
|
|
||
| db.write("end\n") |
There was a problem hiding this comment.
Should also the file be closed?
There was a problem hiding this comment.
File is automatically closed when stepping down to the same indentation level with open was called from.
|
|
||
| #Step 1: Fetch JSON transponder information from SatNOGS db. | ||
| request = urllib2.urlopen("https://db.satnogs.org/api/transmitters") | ||
| data = json.load(request) |
There was a problem hiding this comment.
One of these two lines seem to hang indefinitely (or near indefinitely) when internet is unavailable.
There was a problem hiding this comment.
Could not reproduce with python 2.7.13
There was a problem hiding this comment.
Nevermind, probably network configuration errors on my own end. Fails properly on other configurations.
fetch_satnogs_db.py
Outdated
|
|
||
| # Add transponder data | ||
| db.write("%s - Inverting = %r " %(i['description'], i['invert'])) | ||
| if not i['baud']: |
There was a problem hiding this comment.
Seems to write "Baud = 0" to the file regardless.
…nsponder has a up and downlink. Dead satellites show only as (dead)
fetch_satnogs_db.py
Outdated
| else: | ||
| db.write(" - Non-inverting") | ||
| if transponder['baud']>0: | ||
| db.write(" - Baud = %s " %transponder['baud']) |
There was a problem hiding this comment.
Should remove superfluous space after the baud string.
Fix #49
Adds a python script for getting transponder information from db.satnogs.org/api.