Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue49 missing properties in sun/moon calculations #76

Merged
merged 2 commits into from
Nov 25, 2017

Conversation

bjorgan
Copy link
Member

@bjorgan bjorgan commented Jun 20, 2017

Solve #49 by ignoring all the suggestions and adding extra functions for each of the missing properties without modifying the existing API.

@ryeng ryeng self-requested a review November 25, 2017 15:47
Copy link
Contributor

@ryeng ryeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjorgan bjorgan merged commit 7ca5eff into master Nov 25, 2017
@bjorgan bjorgan deleted the issue49-missing-properties branch November 25, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants