Fix for #90 and #142 on Apple Silicon Devices #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 issues that I encountered running the program on an M1 Mac:
The app as packaged on the "Releases" Page fails to open. This is due to the way that ARM Macs require all applications to be signed. This PR adds code signing for the .app file (but users will still have to grant the app an exception for the first time as it is not signed by an Apple Developer account, see here)
Newer versions of MacOS require the Microphone permission to be granted for the audio routing to work. This is achieved by adding the
NSMicrophoneUsageDescriptionparameter to the Info.plist file so the user is prompted to grant the app permission.