Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size_t
is unsigned, sosp_blocking_read()
errors are cast to a non-negative value and skip the check on line 111.This also causes
bytes_read
to appear to be a very large number (much bigger thanserial_read_size
) which sends lots of junk to the SLIP call and eventually causes a segfault.This can be duplicated for test by starting the M8 without an SD card inserted or by unplugging the M8 from USB after it has launched.
Old behavior: Floods of
SLIP error 1
messages, then a segfault.New behavior:
(program terminates)