Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Interactive Sequence Feature #8

Closed
wants to merge 4 commits into from

Conversation

strangemethod
Copy link

Adds the ability to create a sequence of positions that users can click through with prev/next buttons. A sequence can be creating by simply passing in multiple position strings separated by line breaks. This is meant to be a didactic tool for the demonstrate of opening sequences.

Andrew Bowles and others added 4 commits September 21, 2016 12:25
- Show controls template if multiple boards are defined
- git ignore bower components
- temporarily allow console.logs in eslintrc
Add Interactive Sequence example
- revert eslint settings
@laat
Copy link
Owner

laat commented Sep 23, 2016

This is a really cool example of how <chess-board> could be utilized to create a chess opening visializer. However, I feel this patch violates the single responsibility principle, and makes the chess-board do too much.

What if we made a <chess-opening> component that wraps <chess-board> with previous/next buttons that updates <chess-board> with new fen-strings when the user interacts with the component?

I/We should make this component easier to update with MutationObserver on the content (which is the fen-string), so that a <chess-opening> component is not required to set the fen with chessBoard.fen = '';

This PR has some linting issues, before your next Update/PR please run npm test.

@laat laat closed this Sep 23, 2016
laat added a commit that referenced this pull request Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants