Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lab259/cors and tests for middlewares #16

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Add lab259/cors and tests for middlewares #16

merged 3 commits into from
Jul 29, 2019

Conversation

felipemfp
Copy link
Contributor

We replace fasthttpcors with lab259/cors and improve our code coverage.

@felipemfp felipemfp requested a review from edumarcal July 5, 2019 21:21
@felipemfp felipemfp self-assigned this Jul 5, 2019
@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #16 into master will increase coverage by 2.06%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   93.39%   95.46%   +2.06%     
==========================================
  Files          11       14       +3     
  Lines         545      573      +28     
==========================================
+ Hits          509      547      +38     
+ Misses         26       17       -9     
+ Partials       10        9       -1
Impacted Files Coverage Δ
application.go 82.5% <ø> (+12.04%) ⬆️
fasthttp_service.go 88.88% <0%> (+11.46%) ⬆️
middlewares/cors_middleware.go 100% <100%> (ø)
middlewares/logging_middleware.go 100% <0%> (ø)
middlewares/recoverable_middleware.go 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1fb89...3acce08. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 5, 2019 •
edited
Loading

Codecov Report

Merging #16 into master will increase coverage by 2.06%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   93.39%   95.46%   +2.06%     
==========================================
  Files          11       14       +3     
  Lines         545      573      +28     
==========================================
+ Hits          509      547      +38     
+ Misses         26       17       -9     
+ Partials       10        9       -1
Impacted Files Coverage Δ
application.go 82.5% <ø> (+12.04%) ⬆️
fasthttp_service.go 88.88% <0%> (+11.46%) ⬆️
middlewares/cors_middleware.go 100% <100%> (ø)
middlewares/logging_middleware.go 100% <0%> (ø)
middlewares/recoverable_middleware.go 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1fb89...3acce08. Read the comment docs.

edumarcal
edumarcal approved these changes Jul 8, 2019
View reviewed changes
middlewares/logging_middleware_test.go
handler(ctx3)

logs := buf.String()
Expect(logs).To(ContainSubstring("GET: /something request_id=0"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@felipemfp felipemfp merged commit 0df3165 into master Jul 29, 2019
@felipemfp felipemfp deleted the improve-coverage branch July 29, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edumarcal edumarcal edumarcal approved these changes

Assignees

@felipemfp felipemfp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipemfp @edumarcal