Tomer's USB refactor #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomers
force-pushed
the
tshalev-usb-refactor
branch
from
fc5ad42
to
c558222
Compare
added 13 commits
April 15, 2024 12:53
First step in refactoring. Break this long function into multiple shorter functions.
Next stage in refactoring device management. Move all related logic under a dedicated devices directory.
Another step in the major refactoring of the device management. Added device manager class. I tried to minimize this commit but it is still rather big. I kept the names of files such as detect.py, although the name and functionality has changed. There's still a lot or room to refactor the code. This is merely the first step.
This is preliminary merge, as part of a larger refactor.
No need to set interval, as it is being set by start()
Another step towards better organization of the device and USB classes. This is not the final form of the class hierarchy.
We will add more environment variables in the future, so better have them all in a single place.
In development mode, we may want to print many times without wasting precious label. Setting DEV_MODE_NO_MARGINS=1 as environment variable will now print a short dot char (in GUI app), and without any margin.
tomers
force-pushed
the
tshalev-usb-refactor
branch
from
c558222
to
e7116cf
Compare
maresb
requested changes
Apr 16, 2024
added 2 commits
April 16, 2024 10:54
We will add more environment variables in the future, so better have them all in a single place.
In development mode, we may want to print many times without wasting precious label. Setting DEV_MODE_NO_MARGINS=1 as environment variable will now print a short dot char (in GUI app), and without any margin.
|
Fixed :-) |
maresb
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some initial work towards supporting labeler device selector widget.
@maresb, please take extra care reviewing this, as I had to duplicate my changes in the new repository. I hope I did not revert any of your recent changes related to rebranding the software.